]> git.baikalelectronics.ru Git - kernel.git/commit
cifs: Fix the target file was deleted when rename failed.
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Mon, 29 Jun 2020 01:06:38 +0000 (21:06 -0400)
committerSteve French <stfrench@microsoft.com>
Thu, 2 Jul 2020 00:41:56 +0000 (19:41 -0500)
commitcd0d4035f9db18de8f9b17ffe2ef9cb566d8078f
treec0cfe2bdb4dc73cd6d0f77c5894130bf4c2a280c
parent4ea774a5304c67ad91d6ed0bc7fd2745ca6de821
cifs: Fix the target file was deleted when rename failed.

When xfstest generic/035, we found the target file was deleted
if the rename return -EACESS.

In cifs_rename2, we unlink the positive target dentry if rename
failed with EACESS or EEXIST, even if the target dentry is positived
before rename. Then the existing file was deleted.

We should just delete the target file which created during the
rename.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
fs/cifs/inode.c