]> git.baikalelectronics.ru Git - kernel.git/commit
block, bfq: protect 'bfqd->queued' by 'bfqd->lock'
authorYu Kuai <yukuai3@huawei.com>
Fri, 13 May 2022 02:35:06 +0000 (10:35 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 16 May 2022 17:39:20 +0000 (11:39 -0600)
commitcc7c9ad2fb13a2bbef77a3bd53b1bc53c89836c0
tree863c51bbcc79a13cda5dbfda4106050ed2bf3a36
parent0e7d2903cd0b65deaf9ff2b6754d520802884763
block, bfq: protect 'bfqd->queued' by 'bfqd->lock'

If bfq_schedule_dispatch() is called from bfq_idle_slice_timer_body(),
then 'bfqd->queued' is read without holding 'bfqd->lock'. This is
wrong since it can be wrote concurrently.

Fix the problem by holding 'bfqd->lock' in such case.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220513023507.2625717-2-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c