]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "i915: fix remap_io_sg to verify the pgprot"
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 19 May 2021 15:55:57 +0000 (05:55 -1000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 19 May 2021 15:55:57 +0000 (05:55 -1000)
commitc768af7386d19f65def583f8ac5048a194f410a0
tree10b6a90b0c7e2c03d8640bc9d0b550720b75ebcf
parent09b0d69f8a3a29dddf22c03767ae34670ce590fb
Revert "i915: fix remap_io_sg to verify the pgprot"

This reverts commit aadaf96dca5c7974fd4088d8ae355e556204850e.

It turns out this is not ready for primetime yet.  The intentions are
good, but using remap_pfn_range() requires that there is nothing already
mapped in the area, and the i915 code seems to very much intentionally
remap the same area multiple times.

That will then just trigger the

                BUG_ON(!pte_none(*pte));

in mm/memory.c: remap_pte_range().

There are also reports of mapping type inconsistencies, resulting in
warnings and in screen corruption.

Link: https://lore.kernel.org/lkml/20210519024322.GA29704@xsang-OptiPlex-9020/
Link: https://lore.kernel.org/lkml/YKUjvoaKKggAmpIR@sf/
Link: https://lore.kernel.org/lkml/b6b61cf0-5874-f4c0-1fcc-4b3848451c31@redhat.com/
Reported-by: kernel test robot <oliver.sang@intel.com>
Reported-by: Kalle Valo <kvalo@codeaurora.org>
Reported-by: Hans de Goede <hdegoede@redhat.com>
Reported-by: Sergei Trofimovich <slyfox@gentoo.org>
Acked-by: Christoph Hellwig <hch@lst.de>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/drm/i915/i915_mm.c