]> git.baikalelectronics.ru Git - kernel.git/commit
fs: fix iversion handling
authorChristoph Hellwig <hch@infradead.org>
Tue, 19 Nov 2013 15:17:07 +0000 (07:17 -0800)
committerBen Myers <bpm@sgi.com>
Thu, 5 Dec 2013 22:36:21 +0000 (16:36 -0600)
commitbef4a14bcc1f47df866415e90b0d5637b7981a74
treec0370871b238354313a3809b8911d7f633ed0c3a
parentc8801ac6a9498c9f75451d35b33b9ce54ade17d9
fs: fix iversion handling

Currently notify_change directly updates i_version for size updates,
which not only is counter to how all other fields are updated through
struct iattr, but also breaks XFS, which need inode updates to happen
under its own lock, and synchronized to the structure that gets written
to the log.

Remove the update in the common code, and it to btrfs and ext4,
XFS already does a proper updaste internally and currently gets a
double update with the existing code.

IMHO this is 3.13 and -stable material and should go in through the XFS
tree.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/attr.c
fs/btrfs/inode.c
fs/ext4/inode.c