]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "firmware: arm_scmi: Add clock management to the SCMI power domain"
authorUlf Hansson <ulf.hansson@linaro.org>
Mon, 19 Sep 2022 12:20:33 +0000 (14:20 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 23 Sep 2022 08:19:47 +0000 (10:19 +0200)
commitb80a63377ddc82629a316b8f792447d52bb62b4e
tree7711e7272f9c8d6b74a6bb4431fea8e40efebd2e
parent4baa36ed7bc117bd1b4a08b4f517a3389ff0fdf2
Revert "firmware: arm_scmi: Add clock management to the SCMI power domain"

This reverts commit bb17f79fc8a3 ("firmware: arm_scmi: Add clock management
to the SCMI power domain").

Using the GENPD_FLAG_PM_CLK tells genpd to gate/ungate the consumer
device's clock(s) during runtime suspend/resume through the PM clock API.
More precisely, in genpd_runtime_resume() the clock(s) for the consumer
device would become ungated prior to the driver-level ->runtime_resume()
callbacks gets invoked.

This behaviour isn't a good fit for all platforms/drivers. For example, a
driver may need to make some preparations of its device in its
->runtime_resume() callback, like calling clk_set_rate() before the
clock(s) should be ungated. In these cases, it's easier to let the clock(s)
to be managed solely by the driver, rather than at the PM domain level.

For these reasons, let's drop the use GENPD_FLAG_PM_CLK for the SCMI PM
domain, as to enable it to be more easily adopted across ARM platforms.

Fixes: bb17f79fc8a3 ("firmware: arm_scmi: Add clock management to the SCMI power domain")
Cc: Nicolas Pitre <npitre@baylibre.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20220919122033.86126-1-ulf.hansson@linaro.org
drivers/firmware/arm_scmi/scmi_pm_domain.c