]> git.baikalelectronics.ru Git - kernel.git/commit
scripts/gdb: fix 'lx-dmesg' on 32 bits arch
authorAntonio Borneo <antonio.borneo@foss.st.com>
Tue, 19 Jul 2022 12:28:31 +0000 (14:28 +0200)
committerPetr Mladek <pmladek@suse.com>
Thu, 21 Jul 2022 13:32:52 +0000 (15:32 +0200)
commitb16b046439a25adfebe877bb7a7d351c6afc0aa3
tree6e2693311ac5b129dfaf3fb80b142d70498f2c81
parent537c206b26dd689acaa8803c3494bd0025d86540
scripts/gdb: fix 'lx-dmesg' on 32 bits arch

The type atomic_long_t can have size 4 or 8 bytes, depending on
CONFIG_64BIT; it's only content, the field 'counter', is either an
int or a s64 value.

Current code incorrectly uses the fixed size utils.read_u64() to
read the field 'counter' inside atomic_long_t.

On 32 bits architectures reading the last element 'tail_id' of the
struct prb_desc_ring:
struct prb_desc_ring {
...
atomic_long_t tail_id;
};
causes the utils.read_u64() to access outside the boundary of the
struct and the gdb command 'lx-dmesg' exits with error:
Python Exception <class 'IndexError'>: index out of range
Error occurred in Python: index out of range

Query the really used atomic_long_t counter type size.

Link: https://lore.kernel.org/r/20220617143758.137307-1-antonio.borneo@foss.st.com
Fixes: 9b9edc9291a3 ("scripts/gdb: update for lockless printk ringbuffer")
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
[pmladek@suse.com: Query the really used atomic_long_t counter type size]
Tested-by: Antonio Borneo <antonio.borneo@foss.st.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220719122831.19890-1-pmladek@suse.com
scripts/gdb/linux/dmesg.py
scripts/gdb/linux/utils.py