]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "ALSA: usx2y: Fix potential NULL pointer dereference"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:03 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:51 +0000 (17:33 +0200)
commitaf5f6731db9a1132858100616252c1455475bae5
tree7f6e8f278ef12c4b4a85e562b003451d4d9bf293
parent49f13236e8593f506c70db6d5847b790f760f81d
Revert "ALSA: usx2y: Fix potential NULL pointer dereference"

This reverts commit b7ccb3137cd70ad4d8a0389a26956453258dbd50.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original patch was incorrect, and would leak memory if the error
path the patch added was hit.

Cc: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20210503115736.2104747-37-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/usx2y/usb_stream.c