]> git.baikalelectronics.ru Git - kernel.git/commit
libnvdimm: Out of bounds read in __nd_ioctl()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Feb 2020 16:20:56 +0000 (19:20 +0300)
committerDan Williams <dan.j.williams@intel.com>
Sat, 29 Feb 2020 02:21:52 +0000 (18:21 -0800)
commitaaa6448d1985a0d432036721261bd5cae6aaea4e
tree6a29d775d3d3623ae8068ba8105f2f96cb2fe520
parent0dcec1709324ffd81f5bdac6557f7a283d9160b9
libnvdimm: Out of bounds read in __nd_ioctl()

The "cmd" comes from the user and it can be up to 255.  It it's more
than the number of bits in long, it results out of bounds read when we
check test_bit(cmd, &cmd_mask).  The highest valid value for "cmd" is
ND_CMD_CALL (10) so I added a compare against that.

Fixes: 430ef3231e6d ("libnvdimm: control (ioctl) messages for nvdimm_bus and nvdimm devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200225162055.amtosfy7m35aivxg@kili.mountain
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/bus.c