]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: Intel: Skylake: Acquire irq after RIRB allocation
authorYong Zhi <yong.zhi@intel.com>
Mon, 13 Aug 2018 23:15:14 +0000 (18:15 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 14 Aug 2018 15:21:13 +0000 (16:21 +0100)
commita702540176e50ca420156517205effa6e1a3a764
tree146bbc33e5d02c825d843917c15fe1d181836122
parentbd5f255b8244201a1cb854973920eb580ea15218
ASoC: Intel: Skylake: Acquire irq after RIRB allocation

Cold reboot stress test found that the hda irq could access rirb ring
buffer before its memory gets allocated which resulting in null
pointer dereference inside snd_hdac_bus_update_rirb().

Fix it by moving the skl_acquire_irq after ring buffer allocation.
While here, also change err return from -EBUSY to actual error code.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl.c