]> git.baikalelectronics.ru Git - kernel.git/commit
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 12 Mar 2020 15:17:17 +0000 (10:17 -0500)
committerEric W. Biederman <ebiederm@xmission.com>
Thu, 7 May 2020 21:54:27 +0000 (16:54 -0500)
commita6ed697e132e94715ac57e427bf97a73109c776a
tree0aa2cf5187e06df04c4346f8326a99c82009fe3f
parent955ac135a3b8737477606412c5bb1c4a86e4f4bf
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

In 2016 Linus moved install_exec_creds immediately after
setup_new_exec, in binfmt_elf as a cleanup and as part of closing a
potential information leak.

Perform the same cleanup for the other binary formats.

Different binary formats doing the same things the same way makes exec
easier to reason about and easier to maintain.

Greg Ungerer reports:
> I tested the the whole series on non-MMU m68k and non-MMU arm
> (exercising binfmt_flat) and it all tested out with no problems,
> so for the binfmt_flat changes:
Tested-by: Greg Ungerer <gerg@linux-m68k.org>
Ref: 7ef7b9e2eed4 ("binfmt_elf: switch to new creds when switching to new mm")
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Greg Ungerer <gerg@linux-m68k.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
arch/x86/ia32/ia32_aout.c
fs/binfmt_aout.c
fs/binfmt_elf_fdpic.c
fs/binfmt_flat.c