]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: 3w-9xxx: Avoid disabling device if failing to enable it
authorLetu Ren <fantasquex@gmail.com>
Mon, 29 Aug 2022 11:01:15 +0000 (19:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Sep 2022 02:22:24 +0000 (22:22 -0400)
commit8e711748ccd4007bc1e2e11517ae9a81854da6a0
tree4693dba47b941a182745c7739172870a21746d27
parentf9ae0b994bdadd6a8ee226a5d209aeff7336cfc8
scsi: 3w-9xxx: Avoid disabling device if failing to enable it

The original code will "goto out_disable_device" and call
pci_disable_device() if pci_enable_device() fails. The kernel will generate
a warning message like "3w-9xxx 0000:00:05.0: disabling already-disabled
device".

We shouldn't disable a device that failed to be enabled. A simple return is
fine.

Link: https://lore.kernel.org/r/20220829110115.38789-1-fantasquex@gmail.com
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Letu Ren <fantasquex@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/3w-9xxx.c