]> git.baikalelectronics.ru Git - kernel.git/commit
net: hns: remove ndo_poll_controller
authorEric Dumazet <edumazet@google.com>
Thu, 27 Sep 2018 16:31:54 +0000 (09:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Sep 2018 18:12:28 +0000 (11:12 -0700)
commit82833079a78e8d839a6ec7836c556672663c2a51
tree445956b9569f353c265bfc487e3c1f8e788c17d9
parente5c9bcc8f21d5833c6915d35d4788536c5028034
net: hns: remove ndo_poll_controller

As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.

hns uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_enet.c