]> git.baikalelectronics.ru Git - kernel.git/commit
ath9k: Properly clear TX status area before reporting to mac80211
authorToke Høiland-Jørgensen <toke@toke.dk>
Wed, 30 Mar 2022 16:44:09 +0000 (18:44 +0200)
committerKalle Valo <kvalo@kernel.org>
Fri, 1 Apr 2022 06:36:51 +0000 (09:36 +0300)
commit5e9b0a0f3715af557365bfd8c520ebaa8fcc9e66
treedb48decc3184119188d5f6adbcfbcdd9286a39fc
parent22e3837be53c1873a4605f3766b464dc27ef58be
ath9k: Properly clear TX status area before reporting to mac80211

The ath9k driver was not properly clearing the status area in the
ieee80211_tx_info struct before reporting TX status to mac80211. Instead,
it was manually filling in fields, which meant that fields introduced later
were left as-is.

Conveniently, mac80211 actually provides a helper to zero out the status
area, so use that to make sure we zero everything.

The last commit touching the driver function writing the status information
seems to have actually been fixing an issue that was also caused by the
area being uninitialised; but it only added clearing of a single field
instead of the whole struct. That is now redundant, though, so revert that
commit and use it as a convenient Fixes tag.

Fixes: 3b99c72df9a2 ("ath9k: Make sure to zero status.tx_time before reporting TX status")
Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220330164409.16645-1-toke@toke.dk
drivers/net/wireless/ath/ath9k/xmit.c