]> git.baikalelectronics.ru Git - kernel.git/commit
selftests/livepatch: better synchronize test_klp_callbacks_busy
authorJoe Lawrence <joe.lawrence@redhat.com>
Thu, 2 Jun 2022 20:32:33 +0000 (16:32 -0400)
committerPetr Mladek <pmladek@suse.com>
Wed, 15 Jun 2022 08:29:10 +0000 (10:29 +0200)
commit4e3523b8da916c67ebc612043bd51b4a97a099ae
tree64a40e61665e62d2fa4c2d5b648611e34d6dd6fd
parentcbf9878271beb3014534ba3abdb1ddabd39b22df
selftests/livepatch: better synchronize test_klp_callbacks_busy

The test_klp_callbacks_busy module conditionally blocks a future
livepatch transition by busy waiting inside its workqueue function,
busymod_work_func().  After scheduling this work, a test livepatch is
loaded, introducing the transition under test.

Both events are marked in the kernel log for later verification, but
there is no synchronization to ensure that busymod_work_func() logs its
function entry message before subsequent selftest commands log their own
messages.  This can lead to a rare test failure due to unexpected
ordering like:

  --- expected
  +++ result
  @@ -1,7 +1,7 @@
   % modprobe test_klp_callbacks_busy block_transition=Y
   test_klp_callbacks_busy: test_klp_callbacks_busy_init
  -test_klp_callbacks_busy: busymod_work_func enter
   % modprobe test_klp_callbacks_demo
  +test_klp_callbacks_busy: busymod_work_func enter
   livepatch: enabling patch 'test_klp_callbacks_demo'
   livepatch: 'test_klp_callbacks_demo': initializing patching transition
   test_klp_callbacks_demo: pre_patch_callback: vmlinux

Force the module init function to wait until busymod_work_func() has
started (and logged its message), before exiting to the next selftest
steps.

Fixes: 243adb36ed6d ("selftests/livepatch: simplify test-klp-callbacks busy target tests")
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220602203233.979681-1-joe.lawrence@redhat.com
lib/livepatch/test_klp_callbacks_busy.c