]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: usb-audio: Explicitly set up the clock selector
authorTakashi Iwai <tiwai@suse.de>
Tue, 13 Apr 2021 08:41:52 +0000 (10:41 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 13 Apr 2021 10:05:12 +0000 (12:05 +0200)
commit480503df3470e9b8f3f705c136a959b863be06ca
tree7a1231d3b8e31f0dd51d7ca7d0e57dc12d972a79
parent5d8dde7c64f1401ac8ca9bf47cf3cf0b8044bc6a
ALSA: usb-audio: Explicitly set up the clock selector

In the current code, we have some assumption that the audio clock
selector has been set up implicitly and don't want to touch it unless
it's really needed for the fallback autoclock setup.  This works for
most devices but some seem having a problem.  Partially this was
covered for the devices with a single connector at the initialization
phase (commit 541e3608ddd2 "ALSA: usb-audio: Skip the clock selector
inquiry for single connections"), but also there are cases where the
wrong clock set up is kept silently.  The latter seems to be the cause
of the noises on Behringer devices.

In this patch, we explicitly set up the audio clock selector whenever
the appropriate node is found.

Reported-by: Geraldo Nascimento <geraldogabriel@gmail.com>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199327
Link: https://lore.kernel.org/r/CAEsQvcvF7LnO8PxyyCxuRCx=7jNeSCvFAd-+dE0g_rd1rOxxdw@mail.gmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210413084152.32325-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/clock.c