]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: do not setup backlight if not available according to VBT
authorJani Nikula <jani.nikula@intel.com>
Wed, 9 Apr 2014 08:31:37 +0000 (11:31 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 11 Apr 2014 10:22:57 +0000 (13:22 +0300)
commit42ee9ff585ce54ce4af851c1369c2142461e5714
treebc119a7d1877b34d7421ae0da9ef91a9d0e25ecb
parent4379e7c7bdb43afac524e549eb0bda873ded1da2
drm/i915: do not setup backlight if not available according to VBT

Some machines use an external EC for controlling the backlight. Info
about this is present in the VBT. Do not setup native backlight control
if no PWM backlight is available or supported according to VBT. The
acpi_backlight interface appears to work for the EC control.

In most cases there has been no harm done, but it looks like there are
machines out there that have both an EC and our PWM line connected to
the same wire. This, obviously, does not end well.

This should fix the regression caused by
commit a3bff3c2c3dd6ec38b058cf7aae6b1cbca48ec19
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Thu Nov 14 12:14:29 2013 +0200

    drm/i915: remove QUIRK_NO_PCH_PWM_ENABLE

AFAICT the quirk removed by the above commit effectively resulted in
i915 not driving the backlight PWM output, thus not messing things up.

Additionally this should fix the regression caused by
commit 575a63dd836c9c4c521a1b5e248a5e633addf901
Author: Aaron Lu <aaron.lu@intel.com>
Date:   Fri Oct 11 21:27:45 2013 +0800

    ACPI / video: Do not register backlight if win8 and native interface exists

which left some machines without a functioning backlight interface.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76276
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=47941
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=62281
CC: Aaron Lu <aaron.lu@intel.com>
CC: Eric Griffith <EGriffith92@gmail.com>
CC: Kent Baxley <kent.baxley@canonical.com>
Tested-by: Kamal Mostafa <kamal@canonical.com>
Tested-by: Martin <bugs@mrvanes.com>
Tested-by: jrg.otte@gmail.com
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_panel.c