]> git.baikalelectronics.ru Git - kernel.git/commit
mm/khugepaged: invoke MMU notifiers in shmem/file collapse paths
authorJann Horn <jannh@google.com>
Fri, 25 Nov 2022 21:37:14 +0000 (22:37 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 30 Nov 2022 22:49:42 +0000 (14:49 -0800)
commit41c9e05a531f93dc9d2471152b7c5e419d0ad7d9
treef834a079ef989491ff51dac481179e5e199b8495
parentd3052812b7580aa5fe2ef4726ff9e44ff293d573
mm/khugepaged: invoke MMU notifiers in shmem/file collapse paths

Any codepath that zaps page table entries must invoke MMU notifiers to
ensure that secondary MMUs (like KVM) don't keep accessing pages which
aren't mapped anymore.  Secondary MMUs don't hold their own references to
pages that are mirrored over, so failing to notify them can lead to page
use-after-free.

I'm marking this as addressing an issue introduced in commit eb3c2950d686
("khugepaged: add support of collapse for tmpfs/shmem pages"), but most of
the security impact of this only came in commit 9ded1373a615 ("khugepaged:
enable collapse pmd for pte-mapped THP"), which actually omitted flushes
for the removal of present PTEs, not just for the removal of empty page
tables.

Link: https://lkml.kernel.org/r/20221129154730.2274278-3-jannh@google.com
Link: https://lkml.kernel.org/r/20221128180252.1684965-3-jannh@google.com
Link: https://lkml.kernel.org/r/20221125213714.4115729-3-jannh@google.com
Fixes: eb3c2950d686 ("khugepaged: add support of collapse for tmpfs/shmem pages")
Signed-off-by: Jann Horn <jannh@google.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/khugepaged.c