]> git.baikalelectronics.ru Git - kernel.git/commit
media: ov2680: don't register the v4l2 subdevice before checking chip ID
authorJavier Martinez Canillas <javierm@redhat.com>
Sat, 1 Sep 2018 12:46:29 +0000 (08:46 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 17 Sep 2018 19:19:40 +0000 (15:19 -0400)
commit27a68898f3160a69e55dc73ba0a918fd16586abc
tree8bac0b42bc69f01df3cbacde1a14a22733df9689
parent1d7e6f4d0b1ad4e08fe74893e08d858e5d802070
media: ov2680: don't register the v4l2 subdevice before checking chip ID

The driver registers the v4l2 subdevice before attempting to power on the
chip and checking its ID. This means that a media device driver that it's
waiting for this subdevice to be bound, will prematurely expose its media
device node to userspace because if something goes wrong the media entity
will be cleaned up again on the ov2680 probe function.

This also simplifies the probe function error path since no initialization
is made before attempting to enable the resources or checking the chip ID.

Fixes: 631ad760fcb8 ("media: ov2680: Add Omnivision OV2680 sensor driver")
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/ov2680.c