]> git.baikalelectronics.ru Git - kernel.git/commit
genirq/irqdomain: Check pointer in irq_domain_alloc_irqs_hierarchy()
authorAlexander Sverdlin <alexander.sverdlin@nokia.com>
Fri, 6 Mar 2020 17:47:20 +0000 (18:47 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 8 Mar 2020 12:03:41 +0000 (13:03 +0100)
commit1b1600448e808a906d59ec9220ee892b5b86c029
tree425b4d7de91e0c2c1cbf676de695d045a688e8a7
parent3ed0eda1eb053e0c755d417b179d0a064665de07
genirq/irqdomain: Check pointer in irq_domain_alloc_irqs_hierarchy()

irq_domain_alloc_irqs_hierarchy() has 3 call sites in the compilation unit
but only one of them checks for the pointer which is being dereferenced
inside the called function. Move the check into the function. This allows
for catching the error instead of the following crash:

Unable to handle kernel NULL pointer dereference at virtual address 00000000
PC is at 0x0
LR is at gpiochip_hierarchy_irq_domain_alloc+0x11f/0x140
...
[<c06c23ff>] (gpiochip_hierarchy_irq_domain_alloc)
[<c0462a89>] (__irq_domain_alloc_irqs)
[<c0462dad>] (irq_create_fwspec_mapping)
[<c06c2251>] (gpiochip_to_irq)
[<c06c1c9b>] (gpiod_to_irq)
[<bf973073>] (gpio_irqs_init [gpio_irqs])
[<bf974048>] (gpio_irqs_exit+0xecc/0xe84 [gpio_irqs])
Code: bad PC value

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20200306174720.82604-1-alexander.sverdlin@nokia.com
kernel/irq/irqdomain.c