]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: Explicitly memset the bpf_attr structure
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Mar 2020 09:48:13 +0000 (10:48 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 20 Mar 2020 20:04:30 +0000 (21:04 +0100)
commit0f99e54691c57e64a28efc97ccf7e1b89c4d42c4
treefb6259035e82cb890d5b668479eacb996e26921d
parent8196f4c37faec721656dce9b92d66b77a6456269
bpf: Explicitly memset the bpf_attr structure

For the bpf syscall, we are relying on the compiler to properly zero out
the bpf_attr union that we copy userspace data into. Unfortunately that
doesn't always work properly, padding and other oddities might not be
correctly zeroed, and in some tests odd things have been found when the
stack is pre-initialized to other values.

Fix this by explicitly memsetting the structure to 0 before using it.

Reported-by: Maciej Żenczykowski <maze@google.com>
Reported-by: John Stultz <john.stultz@linaro.org>
Reported-by: Alexander Potapenko <glider@google.com>
Reported-by: Alistair Delva <adelva@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://android-review.googlesource.com/c/kernel/common/+/1235490
Link: https://lore.kernel.org/bpf/20200320094813.GA421650@kroah.com
kernel/bpf/syscall.c