From: Luca Coelho <luciano.coelho@intel.com>
Date: Fri, 26 Jun 2020 09:49:40 +0000 (+0300)
Subject: nl80211: fix memory leak when parsing NL80211_ATTR_HE_BSS_COLOR
X-Git-Tag: baikal/mips/sdk5.9~13212^2~60^2
X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=e0bd67c53daadedea742e8538f91a27d08c9df9a;p=kernel.git

nl80211: fix memory leak when parsing NL80211_ATTR_HE_BSS_COLOR

If there is an error when parsing the NL80211_ATTR_HE_BSS_COLOR
attribute, we return immediately without freeing param.acl.  Fit it by
using goto out instead of returning immediately.

Fixes: 00e60050d41c ("nl80211: add handling for BSS color")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200626124931.7ad2a3eb894f.I60905fb70bd20389a3b170db515a07275e31845e@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index f31698fd4a7e3..0e07fb8585fb4 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5025,7 +5025,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
 					info->attrs[NL80211_ATTR_HE_BSS_COLOR],
 					&params.he_bss_color);
 		if (err)
-			return err;
+			goto out;
 	}
 
 	nl80211_calculate_ap_params(&params);