From: Liu Jian Date: Sat, 3 Dec 2022 09:42:39 +0000 (+0800) Subject: net: hisilicon: Fix potential use-after-free in hisi_femac_rx() X-Git-Tag: baikal/mips/sdk6.1~4304^2~23 X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=9551ebe6c7f0da9f5d3c2e89a18bfadb19c79e83;p=kernel.git net: hisilicon: Fix potential use-after-free in hisi_femac_rx() The skb is delivered to napi_gro_receive() which may free it, after calling this, dereferencing skb may trigger use-after-free. Fixes: 1a4f7c5cc864 ("net: hisilicon: Add Fast Ethernet MAC driver") Signed-off-by: Liu Jian Link: https://lore.kernel.org/r/20221203094240.1240211-1-liujian56@huawei.com Signed-off-by: Paolo Abeni --- diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c index 93846bace0285..ce2571c16e431 100644 --- a/drivers/net/ethernet/hisilicon/hisi_femac.c +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c @@ -283,7 +283,7 @@ static int hisi_femac_rx(struct net_device *dev, int limit) skb->protocol = eth_type_trans(skb, dev); napi_gro_receive(&priv->napi, skb); dev->stats.rx_packets++; - dev->stats.rx_bytes += skb->len; + dev->stats.rx_bytes += len; next: pos = (pos + 1) % rxq->num; if (rx_pkts_num >= limit)