From: Yann Gautier Date: Fri, 25 Nov 2022 09:56:25 +0000 (+0100) Subject: fix(st-gpio): define shift as uint32_t X-Git-Tag: baikal/aarch64/sdk5.10~1^2~309^2 X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=5d942ff1964131bf33f445f66175fe8211c77e23;p=arm-tf.git fix(st-gpio): define shift as uint32_t This corrects MISRA C2012-10.6: The value of a composite expression shall not be assigned to an object with wider essential type. While at it change all the shift values to unsigned. Signed-off-by: Yann Gautier Change-Id: Idf9915313af965db2106095df7cb48a84f50c519 --- diff --git a/drivers/st/gpio/stm32_gpio.c b/drivers/st/gpio/stm32_gpio.c index 708989f70..a4a64ca72 100644 --- a/drivers/st/gpio/stm32_gpio.c +++ b/drivers/st/gpio/stm32_gpio.c @@ -234,27 +234,27 @@ static void set_gpio(uint32_t bank, uint32_t pin, uint32_t mode, uint32_t type, clk_enable(clock); mmio_clrsetbits_32(base + GPIO_MODE_OFFSET, - (uint32_t)GPIO_MODE_MASK << (pin << 1), - mode << (pin << 1)); + (uint32_t)GPIO_MODE_MASK << (pin << 1U), + mode << (pin << 1U)); mmio_clrsetbits_32(base + GPIO_TYPE_OFFSET, (uint32_t)GPIO_TYPE_MASK << pin, type << pin); mmio_clrsetbits_32(base + GPIO_SPEED_OFFSET, - (uint32_t)GPIO_SPEED_MASK << (pin << 1), - speed << (pin << 1)); + (uint32_t)GPIO_SPEED_MASK << (pin << 1U), + speed << (pin << 1U)); mmio_clrsetbits_32(base + GPIO_PUPD_OFFSET, - (uint32_t)GPIO_PULL_MASK << (pin << 1), - pull << (pin << 1)); + (uint32_t)GPIO_PULL_MASK << (pin << 1U), + pull << (pin << 1U)); if (pin < GPIO_ALT_LOWER_LIMIT) { mmio_clrsetbits_32(base + GPIO_AFRL_OFFSET, - (uint32_t)GPIO_ALTERNATE_MASK << (pin << 2), - alternate << (pin << 2)); + (uint32_t)GPIO_ALTERNATE_MASK << (pin << 2U), + alternate << (pin << 2U)); } else { - size_t shift = (pin - GPIO_ALT_LOWER_LIMIT) << 2; + uint32_t shift = (pin - GPIO_ALT_LOWER_LIMIT) << 2U; mmio_clrsetbits_32(base + GPIO_AFRH_OFFSET, (uint32_t)GPIO_ALTERNATE_MASK << shift,