From: Greg Kroah-Hartman Date: Thu, 2 Feb 2023 14:19:19 +0000 (+0100) Subject: powerpc/iommu: fix memory leak with using debugfs_lookup() X-Git-Tag: baikal/mips/sdk6.1~218 X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=4649c2264ee59a03c055a71a64bcb54650db361e;p=kernel.git powerpc/iommu: fix memory leak with using debugfs_lookup() [ Upstream commit b328d819e1cb103b1464039ebcfaad6e8c6336a2 ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Signed-off-by: Greg Kroah-Hartman Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20230202141919.2298821-1-gregkh@linuxfoundation.org Signed-off-by: Sasha Levin --- diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c index caebe1431596e..ee95937bdaf14 100644 --- a/arch/powerpc/kernel/iommu.c +++ b/arch/powerpc/kernel/iommu.c @@ -67,11 +67,9 @@ static void iommu_debugfs_add(struct iommu_table *tbl) static void iommu_debugfs_del(struct iommu_table *tbl) { char name[10]; - struct dentry *liobn_entry; sprintf(name, "%08lx", tbl->it_index); - liobn_entry = debugfs_lookup(name, iommu_debugfs_dir); - debugfs_remove(liobn_entry); + debugfs_lookup_and_remove(name, iommu_debugfs_dir); } #else static void iommu_debugfs_add(struct iommu_table *tbl){}