From: Miaoqian Lin <linmq006@gmail.com>
Date: Fri, 7 Jan 2022 07:31:26 +0000 (+0000)
Subject: soc: qcom: ocmem: Fix missing put_device() call in of_get_ocmem
X-Git-Tag: baikal/mips/sdk5.9~4911
X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=3c084dbb8527a47c5807c71128be428318364c4c;p=kernel.git

soc: qcom: ocmem: Fix missing put_device() call in of_get_ocmem

[ Upstream commit 19528b2de2c0c5e4374c5672795fd0b58f5f7f24 ]

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: 94ca1d6b61c3 ("soc: qcom: ocmem: don't return NULL in of_get_ocmem")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220107073126.2335-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
index f1875dc31ae2c..85f82e195ef8b 100644
--- a/drivers/soc/qcom/ocmem.c
+++ b/drivers/soc/qcom/ocmem.c
@@ -206,6 +206,7 @@ struct ocmem *of_get_ocmem(struct device *dev)
 	ocmem = platform_get_drvdata(pdev);
 	if (!ocmem) {
 		dev_err(dev, "Cannot get ocmem\n");
+		put_device(&pdev->dev);
 		return ERR_PTR(-ENODEV);
 	}
 	return ocmem;