From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 7 Nov 2019 07:48:47 +0000 (+0300)
Subject: block: drbd: remove a stray unlock in __drbd_send_protocol()
X-Git-Tag: baikal/mips/sdk5.9~14997^2~1
X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=29f22a3c095b10ff2d459a06f3f94dd3f47b60b0;p=kernel.git

block: drbd: remove a stray unlock in __drbd_send_protocol()

There are two callers of this function and they both unlock the mutex so
this ends up being a double unlock.

Fixes: b373ea807502 ("drbd: rcu_read_lock() and rcu_dereference() for tconn->net_conf")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 5b248763a6724..a18155cdce416 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -786,7 +786,6 @@ int __drbd_send_protocol(struct drbd_connection *connection, enum drbd_packet cm
 
 	if (nc->tentative && connection->agreed_pro_version < 92) {
 		rcu_read_unlock();
-		mutex_unlock(&sock->mutex);
 		drbd_err(connection, "--dry-run is not supported by peer");
 		return -EOPNOTSUPP;
 	}