From: Miaoqian Lin Date: Wed, 11 May 2022 12:07:37 +0000 (+0400) Subject: rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge X-Git-Tag: baikal/mips/sdk5.9~172 X-Git-Url: https://git.baikalelectronics.ru/?a=commitdiff_plain;h=0783592e04b3972bf7aa4b82be868842a07699b0;p=kernel.git rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge [ Upstream commit 2da6bfb2b12cd7c53f7b7bb309e46c53fda97477 ] of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Fixes: 6d771081793f ("rpmsg: Introduce Qualcomm SMD backend") Signed-off-by: Miaoqian Lin Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220511120737.57374-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 370688e8646bf..c1c07ff39a796 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1380,6 +1380,7 @@ static int qcom_smd_parse_edge(struct device *dev, } edge->ipc_regmap = syscon_node_to_regmap(syscon_np); + of_node_put(syscon_np); if (IS_ERR(edge->ipc_regmap)) { ret = PTR_ERR(edge->ipc_regmap); goto put_node;