video: fbdev: mb862xx: use DEVICE_ATTR_RO macro
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 1 Jun 2021 09:08:52 +0000 (17:08 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 3 Jun 2021 08:32:49 +0000 (10:32 +0200)
Use DEVICE_ATTR_RO helper instead of plain DEVICE_ATTR, which makes the
code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210601090852.10531-1-thunder.leizhen@huawei.com
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c

index 52755b591c1489f1aaad848e5496ee84367d6aca..63721337a37787b74dfcb61998f42fe8686c8e1b 100644 (file)
@@ -542,8 +542,8 @@ static int mb862xxfb_init_fbinfo(struct fb_info *fbi)
 /*
  * show some display controller and cursor registers
  */
-static ssize_t mb862xxfb_show_dispregs(struct device *dev,
-                                      struct device_attribute *attr, char *buf)
+static ssize_t dispregs_show(struct device *dev,
+                            struct device_attribute *attr, char *buf)
 {
        struct fb_info *fbi = dev_get_drvdata(dev);
        struct mb862xxfb_par *par = fbi->par;
@@ -577,7 +577,7 @@ static ssize_t mb862xxfb_show_dispregs(struct device *dev,
        return ptr - buf;
 }
 
-static DEVICE_ATTR(dispregs, 0444, mb862xxfb_show_dispregs, NULL);
+static DEVICE_ATTR_RO(dispregs);
 
 static irqreturn_t mb862xx_intr(int irq, void *dev_id)
 {