wifi: mt76: mt7915: fix memory leak in mt7915_mcu_exit

[ Upstream commit 39ea9e09f3254152376b196fb8891e0a9e6d526e ]

Always purge mcu skb queues in mt7915_mcu_exit routine even if
mt7915_firmware_state fails.

Fixes: c30b8a606f8f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index c4843f4de34ff7171ab69ae1011456d7024adbce..bcfc30d669c20a248e1cc0ac89c0fe7f23d4905e 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -2299,13 +2299,14 @@ void mt7915_mcu_exit(struct mt7915_dev *dev)
        __mt76_mcu_restart(&dev->mt76);
        if (mt7915_firmware_state(dev, false)) {
                dev_err(dev->mt76.dev, "Failed to exit mcu\n");
-               return;
+               goto out;
        }
 
        mt76_wr(dev, MT_TOP_LPCR_HOST_BAND(0), MT_TOP_LPCR_HOST_FW_OWN);
        if (dev->hif2)
                mt76_wr(dev, MT_TOP_LPCR_HOST_BAND(1),
                        MT_TOP_LPCR_HOST_FW_OWN);
+out:
        skb_queue_purge(&dev->mt76.mcu.res_q);
 }