Fix minor issues found by cppcheck

cppcheck highlighted variables that were initialized but then later
reassigned.

Change-Id: Ie12742c01fd3bf48b2d6c05a3b448da91d57a2e4
Signed-off-by: dp-arm <dimitris.papastamos@arm.com>

diff --git a/drivers/io/io_semihosting.c b/drivers/io/io_semihosting.c
index 30ca99cb337b0eedd6701e77c29436502332c8c4..e33a044df4a6f01d44e86c862197cfb4205a56a6 100644 (file)
--- a/drivers/io/io_semihosting.c
+++ b/drivers/io/io_semihosting.c
@@ -95,7 +95,7 @@ static int sh_file_open(io_dev_info_t *dev_info __unused,
                const uintptr_t spec, io_entity_t *entity)
 {
        int result = -ENOENT;
-       long sh_result = -1;
+       long sh_result;
        const io_file_spec_t *file_spec = (const io_file_spec_t *)spec;
 
        assert(file_spec != NULL);
@@ -151,7 +151,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length,
                size_t *length_read)
 {
        int result = -ENOENT;
-       long sh_result = -1;
+       long sh_result;
        size_t bytes = length;
        long file_handle;
 
@@ -176,7 +176,7 @@ static int sh_file_read(io_entity_t *entity, uintptr_t buffer, size_t length,
 static int sh_file_write(io_entity_t *entity, const uintptr_t buffer,
                size_t length, size_t *length_written)
 {
-       long sh_result = -1;
+       long sh_result;
        long file_handle;
        size_t bytes = length;
 
@@ -197,7 +197,7 @@ static int sh_file_write(io_entity_t *entity, const uintptr_t buffer,
 /* Close a file on the semi-hosting device */
 static int sh_file_close(io_entity_t *entity)
 {
-       long sh_result = -1;
+       long sh_result;
        long file_handle;
 
        assert(entity != NULL);

diff --git a/tools/cert_create/src/ext.c b/tools/cert_create/src/ext.c
index 3f56edb756c25f910b19f9ed35b90e1003c93f9e..ad026623d85c9020ef10bcbbc5124fad02a98dc9 100644 (file)
--- a/tools/cert_create/src/ext.c
+++ b/tools/cert_create/src/ext.c
@@ -257,7 +257,7 @@ X509_EXTENSION *ext_new_nvcounter(int nid, int crit, int value)
        X509_EXTENSION *ex = NULL;
        ASN1_INTEGER *counter = NULL;
        unsigned char *p = NULL;
-       int sz = -1;
+       int sz;
 
        /* Encode counter */
        counter = ASN1_INTEGER_new();