net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()

[ Upstream commit 4bdb1e9f63ed06df6b62cac07873f91951c95858 ]

It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.

It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.

In this case, dev_kfree_skb() is called in xemaclite_tx_timeout() to
drop the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().

Fixes: aae0199b4648 ("net: add Xilinx emac lite device driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 6e5ea68b6a7e6e327c50337177fa05d9546e6ace..951482d899f9f66d4e0b232c5b58adc83f937703 100644 (file)
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -541,7 +541,7 @@ static void xemaclite_tx_timeout(struct net_device *dev)
        xemaclite_enable_interrupts(lp);
 
        if (lp->deferred_skb) {
-               dev_kfree_skb(lp->deferred_skb);
+               dev_kfree_skb_irq(lp->deferred_skb);
                lp->deferred_skb = NULL;
                dev->stats.tx_errors++;
        }