kthread: Warn about failed allocations for the init kthread

Failed allocates are not expected when setting up the initial task and
it is not really possible to handle them either.  So I added a warning
to report if such an allocation failure ever happens.

Correct the sense of the warning so it warns when an allocation failure
happens not when the allocation succeeded.  Oops.

Reported-by: kernel test robot <oliver.sang@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Link: https://lkml.kernel.org/r/20211221231611.785b74cf@canb.auug.org.au
Link: https://lkml.kernel.org/r/CA+G9fYvLaR5CF777CKeWTO+qJFTN6vAvm95gtzN+7fw3Wi5hkA@mail.gmail.com
Link: https://lkml.kernel.org/r/20211216102956.GC10708@xsang-OptiPlex-9020
Fixes: aa52bf4ac30d ("kthread: Ensure struct kthread is present for all kthreads")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0404a8c572a1ebd1bec80168e50dd4403180ec36..ee222b89c6924558495f372019a6f550570016de 100644 (file)
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -9425,7 +9425,7 @@ void __init sched_init(void)
         * if we want to avoid special-casing it in code that deals with per-CPU
         * kthreads.
         */
-       WARN_ON(set_kthread_struct(current));
+       WARN_ON(!set_kthread_struct(current));
 
        /*
         * Make us the idle thread. Technically, schedule() should not be