fix(st-clock): use Boolean type for tests

This corrects MISRA C2012-14.4
The controlling expression of an if statement and the controlling
expression of an iteration-statement shall have essentially Boolean type.

Signed-off-by: Yann Gautier <yann.gautier@st.com>
Change-Id: Id217d3da223caf75cd0439d7ce11c9efab87b4d2

diff --git a/drivers/st/clk/clk-stm32-core.c b/drivers/st/clk/clk-stm32-core.c
index bb0312533bfeef9a22e0902890912cc97e41e6a2..d166d5472ad9e19dae44aaec561024c7b7ef109a 100644 (file)
--- a/drivers/st/clk/clk-stm32-core.c
+++ b/drivers/st/clk/clk-stm32-core.c
@@ -519,7 +519,7 @@ static uint8_t _stm32_clk_get_flags(struct stm32_clk_priv *priv, int id)
 
 bool _stm32_clk_is_flags(struct stm32_clk_priv *priv, int id, uint8_t flag)
 {
-       if (_stm32_clk_get_flags(priv, id) & flag) {
+       if ((_stm32_clk_get_flags(priv, id) & flag) != 0U) {
                return true;
        }
 
@@ -549,7 +549,7 @@ static int _clk_stm32_enable_core(struct stm32_clk_priv *priv, int id)
                }
                if (parent != CLK_IS_ROOT) {
                        ret = _clk_stm32_enable_core(priv, parent);
-                       if (ret) {
+                       if (ret != 0) {
                                return ret;
                        }
                }

diff --git a/drivers/st/clk/clk-stm32mp13.c b/drivers/st/clk/clk-stm32mp13.c
index c9609289914d52359aed81ec5dd0f60827f1bb42..05e9ad75e4393d5f0da38d2c814f5d731287b40e 100644 (file)
--- a/drivers/st/clk/clk-stm32mp13.c
+++ b/drivers/st/clk/clk-stm32mp13.c
@@ -1119,7 +1119,7 @@ static int stm32_clk_configure_clk(struct stm32_clk_priv *priv, uint32_t data)
                return ret;
        }
 
-       if (enable) {
+       if (enable != 0) {
                clk_stm32_enable_call_ops(priv, clk_id);
        } else {
                clk_stm32_disable_call_ops(priv, clk_id);
@@ -1450,7 +1450,7 @@ static int _clk_stm32_pll_init(struct stm32_clk_priv *priv, int pll_idx,
 
        /* Configure PLLs source */
        ret = stm32_clk_configure_mux(priv, pll_conf->vco.src);
-       if (ret) {
+       if (ret != 0) {
                return ret;
        }
 
@@ -1485,7 +1485,7 @@ static int clk_stm32_pll_init(struct stm32_clk_priv *priv, int pll_idx)
 {
        struct stm32_pll_dt_cfg *pll_conf = clk_stm32_pll_get_pdata(pll_idx);
 
-       if (pll_conf->vco.status) {
+       if (pll_conf->vco.status != 0U) {
                return _clk_stm32_pll_init(priv, pll_idx, pll_conf);
        }
 
@@ -1497,22 +1497,22 @@ static int stm32_clk_pll_configure(struct stm32_clk_priv *priv)
        int err = 0;
 
        err = clk_stm32_pll_init(priv, _PLL1);
-       if (err) {
+       if (err != 0) {
                return err;
        }
 
        err = clk_stm32_pll_init(priv, _PLL2);
-       if (err) {
+       if (err != 0) {
                return err;
        }
 
        err = clk_stm32_pll_init(priv, _PLL3);
-       if (err) {
+       if (err != 0) {
                return err;
        }
 
        err = clk_stm32_pll_init(priv, _PLL4);
-       if (err) {
+       if (err != 0) {
                return err;
        }