]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drivers: serial: jsm: fix some leaks in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 22 Sep 2022 11:22:47 +0000 (14:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:40 +0000 (13:22 +0200)
[ Upstream commit e33eaaa874f504725e823a9f6ced9deda00b9404 ]

This error path needs to unwind instead of just returning directly.

Fixes: 7e1c6f581ddb ("drivers: serial: jsm: Enable support for Digi Classic adapters")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YyxFh1+lOeZ9WfKO@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/serial/jsm/jsm_driver.c

index 592e51d8944ee8f24ce4587794045fa86e56b396..07e9be9865c78dc3e60261815a6c964683d2e6f6 100644 (file)
@@ -212,7 +212,8 @@ static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 
                break;
        default:
-               return -ENXIO;
+               rc = -ENXIO;
+               goto out_kfree_brd;
        }
 
        rc = request_irq(brd->irq, brd->bd_ops->intr, IRQF_SHARED, "JSM", brd);