scsi: qla2xxx: edif: Send LOGO for unexpected IKE message

If the session is down and the local port continues to receive AUTH ELS
messages, the driver needs to send back LOGO so that the remote device
knows to tear down its session. Terminate and clean up the AUTH ELS
exchange followed by a passthrough LOGO.

Link: https://lore.kernel.org/r/20220608115849.16693-3-njavali@marvell.com
Fixes: ce4d4dd912f3 ("scsi: qla2xxx: edif: Reject AUTH ELS on session down")
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index ca6d724dc09d9c5c123bb02f193797498173b889..bd71b0ef3ed199026af2a7ec3c29f6970f5303d4 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -2565,8 +2565,7 @@ void qla24xx_auth_els(scsi_qla_host_t *vha, void **pkt, struct rsp_que **rsp)
 
        fcport = qla2x00_find_fcport_by_pid(host, &purex->pur_info.pur_sid);
 
-       if (DBELL_INACTIVE(vha) ||
-           (fcport && EDIF_SESSION_DOWN(fcport))) {
+       if (DBELL_INACTIVE(vha)) {
                ql_dbg(ql_dbg_edif, host, 0x0910c, "%s e_dbell.db_flags =%x %06x\n",
                    __func__, host->e_dbell.db_flags,
                    fcport ? fcport->d_id.b24 : 0);
@@ -2576,6 +2575,22 @@ void qla24xx_auth_els(scsi_qla_host_t *vha, void **pkt, struct rsp_que **rsp)
                return;
        }
 
+       if (fcport && EDIF_SESSION_DOWN(fcport)) {
+               ql_dbg(ql_dbg_edif, host, 0x13b6,
+                   "%s terminate exchange. Send logo to 0x%x\n",
+                   __func__, a.did.b24);
+
+               a.tx_byte_count = a.tx_len = 0;
+               a.tx_addr = 0;
+               a.control_flags = EPD_RX_XCHG;  /* EPD_RX_XCHG = terminate cmd */
+               qla_els_reject_iocb(host, (*rsp)->qpair, &a);
+               qla_enode_free(host, ptr);
+               /* send logo to let remote port knows to tear down session */
+               fcport->send_els_logo = 1;
+               qlt_schedule_sess_for_deletion(fcport);
+               return;
+       }
+
        /* add the local enode to the list */
        qla_enode_add(host, ptr);
 

diff --git a/drivers/scsi/qla2xxx/qla_fw.h b/drivers/scsi/qla2xxx/qla_fw.h
index 0bb1d562f0bfc6b7527a192c8b4603624701c244..361015b5763ef5e944c50d74907384bdeea69168 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_fw.h
+++ b/drivers/scsi/qla2xxx/qla_fw.h
@@ -807,7 +807,7 @@ struct els_entry_24xx {
 #define EPD_ELS_COMMAND                (0 << 13)
 #define EPD_ELS_ACC            (1 << 13)
 #define EPD_ELS_RJT            (2 << 13)
-#define EPD_RX_XCHG            (3 << 13)
+#define EPD_RX_XCHG            (3 << 13)  /* terminate exchange */
 #define ECF_CLR_PASSTHRU_PEND  BIT_12
 #define ECF_INCL_FRAME_HDR     BIT_11
 #define ECF_SEC_LOGIN          BIT_3