fix(el3-spmc): deadlock when relinquishing memory

Do not forget to pass via err_unlock_mailbox: label.

Change-Id: Icfb997b1c7cce196003af2c28bffc50dc73e30b4
Signed-off-by: Lukas Hanel <lukas.hanel@trustonic.com>

diff --git a/services/std_svc/spm/el3_spmc/spmc_shared_mem.c b/services/std_svc/spm/el3_spmc/spmc_shared_mem.c
index 5a3fe94cd191233009095890c1093d95878b20ae..e137346e0b4740825db5835826c1ca5452fbf818 100644 (file)
--- a/services/std_svc/spm/el3_spmc/spmc_shared_mem.c
+++ b/services/std_svc/spm/el3_spmc/spmc_shared_mem.c
@@ -1347,7 +1347,8 @@ spmc_ffa_mem_retrieve_req(uint32_t smc_fid,
        if (req->emad_count == 0U) {
                WARN("%s: unsupported attribute desc count %u.\n",
                     __func__, obj->desc.emad_count);
-               return -EINVAL;
+               ret = FFA_ERROR_INVALID_PARAMETER;
+               goto err_unlock_mailbox;
        }
 
        /* Determine the appropriate minimum descriptor size. */