]> git.baikalelectronics.ru Git - kernel.git/commitdiff
usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 3 Jun 2022 14:12:30 +0000 (18:12 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:17:52 +0000 (11:17 +0200)
[ Upstream commit 4e0a6ddcef6ac66de178e427553ef4c6e94630f0 ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 0775db4aa75f ("USB: ohci-nxp: Use isp1301 driver")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603141231.979-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ohci-nxp.c

index c561881d0e793d445ab16be0c3acf7ac7c5b9cd0..07cee8c7c25ed71dec3f226d503392e1fb926d8d 100644 (file)
@@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
        }
 
        isp1301_i2c_client = isp1301_get_client(isp1301_node);
+       of_node_put(isp1301_node);
        if (!isp1301_i2c_client)
                return -EPROBE_DEFER;