]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: pm8001: Fix __iomem pointer use in pm8001_phy_control()
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sun, 20 Feb 2022 03:17:41 +0000 (12:17 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Feb 2022 02:31:16 +0000 (21:31 -0500)
Avoid the sparse warning "warning: cast removes address space '__iomem' of
expression" by declaring the qp pointer as "u32 __iomem *".  Accordingly,
change the accesses to the qp array to use readl().

Link: https://lore.kernel.org/r/20220220031810.738362-3-damien.lemoal@opensource.wdc.com
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_sas.c

index 828d719afa1b2c9269b9fe59033b6b361e7be1da..f5678be4c17bbdea4349542c8c5af8d2500becba 100644 (file)
@@ -234,14 +234,13 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
                }
                {
                        struct sas_phy *phy = sas_phy->phy;
-                       uint32_t *qp = (uint32_t *)(((char *)
-                               pm8001_ha->io_mem[2].memvirtaddr)
-                               + 0x1034 + (0x4000 * (phy_id & 3)));
-
-                       phy->invalid_dword_count = qp[0];
-                       phy->running_disparity_error_count = qp[1];
-                       phy->loss_of_dword_sync_count = qp[3];
-                       phy->phy_reset_problem_count = qp[4];
+                       u32 __iomem *qp = pm8001_ha->io_mem[2].memvirtaddr
+                               + 0x1034 + (0x4000 * (phy_id & 3));
+
+                       phy->invalid_dword_count = readl(qp);
+                       phy->running_disparity_error_count = readl(&qp[1]);
+                       phy->loss_of_dword_sync_count = readl(&qp[3]);
+                       phy->phy_reset_problem_count = readl(&qp[4]);
                }
                if (pm8001_ha->chip_id == chip_8001)
                        pm8001_bar4_shift(pm8001_ha, 0);