]> git.baikalelectronics.ru Git - arm-tf.git/commitdiff
fix(nxp-ddr): fix underrun coverity issue
authorPankaj Gupta <pankaj.gupta@nxp.com>
Tue, 16 Aug 2022 08:18:34 +0000 (13:48 +0530)
committerJiafei Pan <Jiafei.Pan@nxp.com>
Wed, 23 Nov 2022 01:17:48 +0000 (09:17 +0800)
Coverity Issue detail:

underrun-local: Underrunning array bin[i].cl[k].caslat
                at element index -1 (byte offset -1)
                using index j (which evaluates to -1).

Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Change-Id: I1ec4833bbd5db1ac51436eac606484eefc4338ee

drivers/nxp/ddr/nxp-ddr/regs.c

index cedd7ca09e69df1d2ae096263173586912a0e122..26155abe09bbae41fbf7942ab8fb19df27c33295 100644 (file)
@@ -1302,7 +1302,7 @@ static unsigned int skip_caslat(unsigned int tckmin_ps,
                return 0;
        }
 
-       if ((bin[i].taamin_ps[j] == 0) ||
+       if (((bin[i].taamin_ps[j] == 0) && j > 0) ||
            (bin[i].taamin_ps[j] > taamin_ps && j > 0)) {
                j--;
        }