]> git.baikalelectronics.ru Git - kernel.git/commitdiff
thermal/drivers/hisi: Drop second sensor hi3660
authorYongqin Liu <yongqin.liu@linaro.org>
Fri, 10 Feb 2023 14:15:07 +0000 (22:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:43:43 +0000 (16:43 +0100)
[ Upstream commit 15cc25829a97c3957e520e971868aacc84341317 ]

The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm
allocators") exposes a panic "BRK handler: Fatal exception" on the
hi3660_thermal_probe funciton.
This is because the function allocates memory for only one
sensors array entry, but tries to fill up a second one.

Fix this by removing the unneeded second access.

Fixes: 61f737b2c781 ("thermal/drivers/hisi: Fix number of sensors on hi3660")
Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
Link: https://lore.kernel.org/linux-mm/20221101223321.1326815-5-keescook@chromium.org/
Link: https://lore.kernel.org/r/20230210141507.71014-1-yongqin.liu@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/thermal/hisi_thermal.c

index 2d26ae80e20228e96bcb2e4b4a2958f2dd57bbee..bee6d3524e52a73a4f8aed92c7e3173e46f21033 100644 (file)
@@ -435,10 +435,6 @@ static int hi3660_thermal_probe(struct hisi_thermal_data *data)
        data->sensor[0].irq_name = "tsensor_a73";
        data->sensor[0].data = data;
 
-       data->sensor[1].id = HI3660_LITTLE_SENSOR;
-       data->sensor[1].irq_name = "tsensor_a53";
-       data->sensor[1].data = data;
-
        return 0;
 }