]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ipmi:ssif: Remove rtc_us_timer
authorCorey Minyard <cminyard@mvista.com>
Wed, 25 Jan 2023 16:41:48 +0000 (10:41 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Mar 2023 07:50:19 +0000 (08:50 +0100)
[ Upstream commit dcbc1da660b746c0aaab2fe9cb9497a4937892aa ]

It was cruft left over from older handling of run to completion.

Cc: stable@vger.kernel.org
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/ipmi_ssif.c

index 7c606c49cd5350106c95d7ab7e25369ab36273d2..cbd56886f1d2a8fd8b3adbf9d2dbaba5996cb568 100644 (file)
@@ -241,12 +241,6 @@ struct ssif_info {
         */
        bool                req_flags;
 
-       /*
-        * Used to perform timer operations when run-to-completion
-        * mode is on.  This is a countdown timer.
-        */
-       int                 rtc_us_timer;
-
        /* Used for sending/receiving data.  +1 for the length. */
        unsigned char data[IPMI_MAX_MSG_LENGTH + 1];
        unsigned int  data_len;
@@ -530,7 +524,6 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result,
 
 static void start_get(struct ssif_info *ssif_info)
 {
-       ssif_info->rtc_us_timer = 0;
        ssif_info->multi_pos = 0;
 
        ssif_i2c_send(ssif_info, msg_done_handler, I2C_SMBUS_READ,
@@ -622,7 +615,6 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result,
 
                        flags = ipmi_ssif_lock_cond(ssif_info, &oflags);
                        ssif_info->waiting_alert = true;
-                       ssif_info->rtc_us_timer = SSIF_MSG_USEC;
                        if (!ssif_info->stopping)
                                mod_timer(&ssif_info->retry_timer,
                                          jiffies + SSIF_MSG_JIFFIES);
@@ -973,7 +965,6 @@ static void msg_written_handler(struct ssif_info *ssif_info, int result,
                        /* Wait a jiffie then request the next message */
                        ssif_info->waiting_alert = true;
                        ssif_info->retries_left = SSIF_RECV_RETRIES;
-                       ssif_info->rtc_us_timer = SSIF_MSG_PART_USEC;
                        if (!ssif_info->stopping)
                                mod_timer(&ssif_info->retry_timer,
                                          jiffies + SSIF_MSG_PART_JIFFIES);