tracing/hist: Fix wrong return value in parse_action_params()

commit 2cc6a528882d0e0ccbc1bca5f95b8c963cedac54 upstream.

When number of synth fields is more than SYNTH_FIELDS_MAX,
parse_action_params() should return -EINVAL.

Link: https://lore.kernel.org/linux-trace-kernel/20221207034635.2253990-1-zhengyejian1@huawei.com
Cc: <mhiramat@kernel.org>
Cc: <zanussi@kernel.org>
Cc: stable@vger.kernel.org
Fixes: c97d1e6596e0 ("tracing: Add 'onmatch' hist trigger action support")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index b97412053c0a6e90953fb698d75356b53fd4cf4e..c6e406995c11247c934f31dd5fe21d83b408b1c1 100644 (file)
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -3588,6 +3588,7 @@ static int parse_action_params(struct trace_array *tr, char *params,
        while (params) {
                if (data->n_params >= SYNTH_FIELDS_MAX) {
                        hist_err(tr, HIST_ERR_TOO_MANY_PARAMS, 0);
+                       ret = -EINVAL;
                        goto out;
                }