]> git.baikalelectronics.ru Git - kernel.git/commitdiff
sh: sq: Fix incorrect element size for allocating bitmap buffer
authorJohn Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Wed, 19 Apr 2023 11:48:52 +0000 (13:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:35:49 +0000 (11:35 +0200)
[ Upstream commit 80f746e2bd0e1da3fdb49a53570e54a1a225faac ]

The Store Queue code allocates a bitmap buffer with the size of
multiple of sizeof(long) in sq_api_init(). While the buffer size
is calculated correctly, the code uses the wrong element size to
allocate the buffer which results in the allocated bitmap buffer
being too small.

Fix this by allocating the buffer with kcalloc() with element size
sizeof(long) instead of kzalloc() whose elements size defaults to
sizeof(char).

Fixes: f3b8392e43aa ("sh: Store Queue API rework.")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Link: https://lore.kernel.org/r/20230419114854.528677-1-glaubitz@physik.fu-berlin.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/sh/kernel/cpu/sh4/sq.c

index 934ff84844fa0bb8819d89fb7a13cf6ee00aa9a3..c633fe4d7039812b4edd2740c81ce63673f3ab8e 100644 (file)
@@ -380,7 +380,7 @@ static int __init sq_api_init(void)
        if (unlikely(!sq_cache))
                return ret;
 
-       sq_bitmap = kzalloc(size, GFP_KERNEL);
+       sq_bitmap = kcalloc(size, sizeof(long), GFP_KERNEL);
        if (unlikely(!sq_bitmap))
                goto out;