]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ep_create_wakeup_source(): dentry name can change under you...
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 24 Sep 2020 23:41:58 +0000 (19:41 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 24 Sep 2020 23:41:58 +0000 (19:41 -0400)
or get freed, for that matter, if it's a long (separately stored)
name.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/eventpoll.c

index 16313180e4c16b95044d69c0425237585d434bce..4df61129566d40a21f7016b0900565cdaf68f463 100644 (file)
@@ -1448,7 +1448,7 @@ static int reverse_path_check(void)
 
 static int ep_create_wakeup_source(struct epitem *epi)
 {
-       const char *name;
+       struct name_snapshot n;
        struct wakeup_source *ws;
 
        if (!epi->ep->ws) {
@@ -1457,8 +1457,9 @@ static int ep_create_wakeup_source(struct epitem *epi)
                        return -ENOMEM;
        }
 
-       name = epi->ffd.file->f_path.dentry->d_name.name;
-       ws = wakeup_source_register(NULL, name);
+       take_dentry_name_snapshot(&n, epi->ffd.file->f_path.dentry);
+       ws = wakeup_source_register(NULL, n.name.name);
+       release_dentry_name_snapshot(&n);
 
        if (!ws)
                return -ENOMEM;