]> git.baikalelectronics.ru Git - kernel.git/commitdiff
macintosh: via-pmu-led: requires ATA to be set
authorRandy Dunlap <rdunlap@infradead.org>
Thu, 23 Feb 2023 01:42:41 +0000 (17:42 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 09:35:50 +0000 (11:35 +0200)
[ Upstream commit 05dce4ba125336875cd3eed3c1503fa81cd2f691 ]

LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
  Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
  Selected by [y]:
  - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]

Fix this by making ADB_PMU_LED_DISK depend on ATA.

Seen on both PPC32 and PPC64.

Fixes: a72f72f97e8a ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230223014241.20878-1-rdunlap@infradead.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/macintosh/Kconfig

index b5a534206edddd52063339daa3201d68efa2e673..1605dcaa89e303b3440e6765210d118c8d71ff6e 100644 (file)
@@ -86,6 +86,7 @@ config ADB_PMU_LED
 
 config ADB_PMU_LED_DISK
        bool "Use front LED as DISK LED by default"
+       depends on ATA
        depends on ADB_PMU_LED
        depends on LEDS_CLASS
        select LEDS_TRIGGERS