]> git.baikalelectronics.ru Git - kernel.git/commitdiff
regulator: pfuze100: Fix the global-out-of-bounds access in pfuze100_regulator_probe()
authorXiaolei Wang <xiaolei.wang@windriver.com>
Thu, 25 Aug 2022 11:19:22 +0000 (19:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:03:58 +0000 (11:03 +0200)
[ Upstream commit 7888f2210613e9e307c85f3657dddd463de0f5ab ]

The pfuze_chip::regulator_descs is an array of size
PFUZE100_MAX_REGULATOR, the pfuze_chip::pfuze_regulators
is the pointer to the real regulators of a specific device.
The number of real regulator is supposed to be less than
the PFUZE100_MAX_REGULATOR, so we should use the size of
'regulator_num * sizeof(struct pfuze_regulator)' in memcpy().
This fixes the out of bounds access bug reported by KASAN.

Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Link: https://lore.kernel.org/r/20220825111922.1368055-1-xiaolei.wang@windriver.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/pfuze100-regulator.c

index f873d97100e28121bfb006440494cacd166458b2..13609942d45c0c32d678494507271747fdfb1c8f 100644 (file)
@@ -788,7 +788,7 @@ static int pfuze100_regulator_probe(struct i2c_client *client,
                ((pfuze_chip->chip_id == PFUZE3000) ? "3000" : "3001"))));
 
        memcpy(pfuze_chip->regulator_descs, pfuze_chip->pfuze_regulators,
-               sizeof(pfuze_chip->regulator_descs));
+               regulator_num * sizeof(struct pfuze_regulator));
 
        ret = pfuze_parse_regulators_dt(pfuze_chip);
        if (ret)