media: lirc: ensure lirc device receives repeats

Pressing a button on a remote control unit will typically lead to
messages being sent several times per second until the button is released.

Some remote control units indicate long key presses by sending
special "repeat" messages, for which the protocol driver calls
rc_repeat(). Other units repeat the same message over and over,
which will be handled by calling rc_keydown().

The function rc_keydown() never set the LIRC "repeat" flag to distinguish
repeated messages that were sent due to a long keypress, and messages
sent due to repeated short keypresses. While a user-space program may
implement special logic to distinguish long keypresses, it is much simpler
to be able to rely on the flag.

Commit 8ad62b00cf86fe0985f3a69f45a18724f5f7babf ("media: lirc: implement
reading scancode") would never set the LIRC_SCANCODE_FLAG_REPEAT flag.
Commit fb59778b0b1eda56ac166f489089bbe92bd7e85d
("media: lirc: ensure lirc device receives nec repeats") fixed it up for
rc_repeat() but not rc_keydown().

Signed-off-by: Marko Mäkelä <marko.makela@iki.fi>
Co-developed-by: Sean Young <sean@mess.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 923cc1acda94241f966cd33b458747a539ff7667..eba0cd30e314d75ee826e7db3b751a4993160e5b 100644 (file)
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -786,7 +786,8 @@ static void ir_do_keydown(struct rc_dev *dev, enum rc_proto protocol,
                          dev->last_toggle   != toggle);
        struct lirc_scancode sc = {
                .scancode = scancode, .rc_proto = protocol,
-               .flags = toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0,
+               .flags = (toggle ? LIRC_SCANCODE_FLAG_TOGGLE : 0) |
+                        (!new_event ? LIRC_SCANCODE_FLAG_REPEAT : 0),
                .keycode = keycode
        };