]> git.baikalelectronics.ru Git - kernel.git/commitdiff
arm64: Correct wrong label in macro __init_el2_gicv3
authorJoakim Tjernlund <joakim.tjernlund@infinera.com>
Mon, 14 Feb 2022 17:56:43 +0000 (18:56 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Mon, 14 Feb 2022 18:37:07 +0000 (18:37 +0000)
In commit:

  e3289966ed2fbc2a ("arm64: Fix labels in el2_setup macros")

We renamed a label from '1' to '.Lskip_gicv3_\@', but failed to update
a branch to it, which now targets a later label also called '1'.

The branch is taken rarely, when GICv3 is present but SRE is disabled
at EL3, causing a boot-time crash.

Update the caller to the new label name.

Fixes: e3289966ed2f ("arm64: Fix labels in el2_setup macros")
Cc: <stable@vger.kernel.org> # 5.12.x
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Link: https://lore.kernel.org/r/20220214175643.21931-1-joakim.tjernlund@infinera.com
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/include/asm/el2_setup.h

index 3198acb2aad8c5c858b6b6cda28f2e7d8e8121d2..7f3c87f7a0cec758928c9d46dcce97058b0e413e 100644 (file)
        msr_s   SYS_ICC_SRE_EL2, x0
        isb                                     // Make sure SRE is now set
        mrs_s   x0, SYS_ICC_SRE_EL2             // Read SRE back,
-       tbz     x0, #0, 1f                      // and check that it sticks
+       tbz     x0, #0, .Lskip_gicv3_\@         // and check that it sticks
        msr_s   SYS_ICH_HCR_EL2, xzr            // Reset ICC_HCR_EL2 to defaults
 .Lskip_gicv3_\@:
 .endm