]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 2 Feb 2023 20:45:36 +0000 (21:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:50:31 +0000 (12:50 +0100)
[ Upstream commit 69ff53e4a4c9498eeed7d1441f68a1481dc69251 ]

Jerome provided the information that also the GXL internal PHY doesn't
support MMD register access and EEE. MMD reads return 0xffff, what
results in e.g. completely wrong ethtool --show-eee output.
Therefore use the MMD dummy stubs.

Fixes: 0c3199d820c1 ("net: phy: add an option to disable EEE advertisement")
Suggested-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/84432fe4-0be4-bc82-4e5c-557206b40f56@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/meson-gxl.c

index f7a9e6599a64297cdef2837a7445d56f6b4a9a0c..39151ec6f65e23c90b3cab6eef8a6d7e64a6a97f 100644 (file)
@@ -235,6 +235,8 @@ static struct phy_driver meson_gxl_phy[] = {
                .config_intr    = meson_gxl_config_intr,
                .suspend        = genphy_suspend,
                .resume         = genphy_resume,
+               .read_mmd       = genphy_read_mmd_unsupported,
+               .write_mmd      = genphy_write_mmd_unsupported,
        }, {
                PHY_ID_MATCH_EXACT(0x01803301),
                .name           = "Meson G12A Internal PHY",