media: c8sectpfe: Add of_node_put() when breaking out of loop

[ Upstream commit b2e4032215c0a9e97e9afe75b851a484b23a6fc4 ]

In configure_channels(), we should call of_node_put() when breaking
out of for_each_child_of_node() which will automatically increase
and decrease the refcount.

Fixes: b754abbeb59e ("[media] c8sectpfe: STiH407/10 Linux DVB demux support")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
index cefe6b7bfdc4ea5f592724adc91317bd64881618..1dbb89f0ddb8cb31653b2df0581ce5619ce2f305 100644 (file)
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c
@@ -925,6 +925,7 @@ static int configure_channels(struct c8sectpfei *fei)
                if (ret) {
                        dev_err(fei->dev,
                                "configure_memdma_and_inputblock failed\n");
+                       of_node_put(child);
                        goto err_unmap;
                }
                index++;